fix(runtime): ensured attributes are forwarded to createScript hook#2799
Merged
zhoushaw merged 3 commits intomodule-federation:mainfrom Jul 30, 2024
Merged
fix(runtime): ensured attributes are forwarded to createScript hook#2799zhoushaw merged 3 commits intomodule-federation:mainfrom
zhoushaw merged 3 commits intomodule-federation:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d55b9c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
@zhoushaw @ScriptedAlchemy is this something that could be merged in the near future? It's blocking some of the work we're doing at my company. Happy to make changes if needed, just let me know. Thanks! |
zhoushaw
approved these changes
Jul 30, 2024
Collaborator
|
Thank you for your contribution. LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In NextJS, with a recent update to the nextjs-mf plugin, the app will immediately crash in the browser with "TypeError: Cannot convert undefined or null to object" because the
attrsobject is undefined in the next-internal-plugin createScript hook. It looks like there were a couple of places where onlyurlwas passed to the hook, and in those cases the runtime plugin bundled with nextjs-mf would fail when createScript was emitted.The error appears only to surface when using the manifest in NextJS, but I think the underlying issue is that
attrsis expected by the hook but it isn't present when preloading.Related Issue
Steps to reproduce:
nextjs-ssr-manifestexample from this PR: feat(nextjs-mf): added nextjs-ssr-manifest example module-federation-examples#4231@module-federation/*dependencies to their latest versions (as of now:nextjs-mf@8.4.4,enhanced@0.3.1)npm startTypes of changes
Checklist